Re: [PATCH] ath3k: reduce memory usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

Am 30.11.2010 02:52, schrieb Gustavo F. Padovan:
-	if ((usb_control_msg(data->udev, pipe,
+	send_buf = kmalloc(BULK_SIZE, GFP_ATOMIC);
+	if (!send_buf) {
+		BT_ERR("Can't allocate memory chunk for firmware");
+		return -ENOMEM;
+	}
+
+	memcpy(send_buf, firmware->data, 20);
+	if ((err = usb_control_msg(udev, pipe,
  				USB_REQ_DFU_DNLOAD,
  				USB_TYPE_VENDOR, 0, 0,
-				firmware, 20, USB_CTRL_SET_TIMEOUT))<  0) {
+				send_buf, 20, USB_CTRL_SET_TIMEOUT))<  0) {
  		BT_ERR("Can't change to loading configuration err");
-		return -EBUSY;
+		goto error;
  	}
  	sent += 20;
  	count -= 20;

Patch looks good to me,  but I have a question here: what's 20 here? I
didn't figured out.

I don't know. I assume it's a stub which has to be send before the real firmware. It already was there and I haven't touched that.

Regards,

Alexander
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux