Hi Anderson,
> Hi Andrei,
>
> On Fri, Nov 26, 2010 at 11:22 AM, Emeltchenko Andrei
> <Andrei.Emeltchenko.news@xxxxxxxxx> wrote:
> > @@ -430,7 +433,8 @@ int hci_inquiry(void __user *arg)
> > Â Â Â Âhci_dev_unlock_bh(hdev);
> >
> > Â Â Â Âtimeo = ir.length * msecs_to_jiffies(2000);
> > - Â Â Â if (do_inquiry && (err = hci_request(hdev, hci_inq_req,
> > (unsigned long)&ir, timeo)) < 0) + Â Â Â err = hci_request(hdev,
> > hci_inq_req, (unsigned long)&ir, timeo); + Â Â Â if (do_inquiry && err
> > < 0)Â Â Â Â Â Â Â Âgoto done;
>
> I think there is a problem here. the "do_inquiry" flag will be checked
> *after* the inquiry request is done. Maybe you should do something
> like:
>
> if (do_inquiry) {
>Â Â Â Â err = hci_request(hdev, hci_inq_req,sur (unsigned long)&ir, timeo);
>Â Â Â Â if (err < 0)
>Â Â Â Â Â Â Â Â goto done;
> }
sure, thanks for reviewing.
Will rewrite this part.
-- Andrei
>
> Regards,
> --
> Anderson Lizardo
> OpenBossa Labs - INdT
> Manaus - Brazil
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
