Hi Suraj,
On Tue, Nov 23, 2010, Suraj Sumangala wrote:
> The set_speed function is defined in hciattach.c as
>
> int set_speed(...)
> {
> cfsetospeed(...);
> cfsetispeed(...);
> return tcsetattr(...);
> }
>
> I think this function could end up returning Success even if the
> first two function calls failed?
Seems so, yes.
> Does it makes sense to rewrite it to
>
> int set_speed(...)
> {
> if(cfsetospeed(...) < 0)
> return -errno;
> if(cfsetispeed(...) < 0)
> return -errno;
This looks fine, except for the coding style: space between if and (
> return tcsetattr(...);
I guess this should be a similar if statement as for the other two
calls, and then a final "return 0" at the end of the function. This
set_speed fix should be in a separate patch though.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
