Hi Gustavo,
On Mon, Nov 22, 2010 at 1:34 PM, Gustavo F. Padovan
<padovan@xxxxxxxxxxxxxx> wrote:
> * Anderson Lizardo <anderson.lizardo@xxxxxxxxxxxxx> [2010-11-22 06:57:14 -0400]:
>> diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
>> index 18a802c..7980e24 100644
>> --- a/net/bluetooth/l2cap.c
>> +++ b/net/bluetooth/l2cap.c
>> @@ -4875,8 +4875,10 @@ static int __init l2cap_init(void)
>> return err;
>>
>> _busy_wq = create_singlethread_workqueue("l2cap");
>> - if (!_busy_wq)
>> - goto error;
>> + if (!_busy_wq) {
>> + err = -ENOMEM;
>> + goto error_busy_wq;
>> + }
>
> I prefer if you move the workqueue creation to after the
> hci_register_proto block. That will make things easier.
I wonder if that might not introduce a race condition, because after
hci_register_proto() new connections may already arrive?
Or is it guaranteed to only happen after l2cap_init() has finished?
If not, I can make this change without problem.
Regards,
--
Anderson Lizardo
OpenBossa Labs - INdT
Manaus - Brazil
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
