* Johan Hedberg <johan.hedberg@xxxxxxxxx> [2010-11-18 00:30:57 +0200]: > Hi Gustavo, > > On Tue, Nov 16, 2010, Gustavo F. Padovan wrote: > > > -static int request_outgoing_auth(struct hci_dev *hdev, bdaddr_t *bdaddr) > > > +static int outgoing_auth_needed(struct hci_dev *hdev, bdaddr_t *bdaddr) > > > > Can you add a hci_ in the beginning of your functions, just to keep the > > coherency with the rest of the code. > > Sure. I guess I'm too used to the userspace convention where strict > namespacing is only used for exported (non-static) functions. > > > I'm not happy with have to lookup the hci_conn twice when we can do that > > once here. I've noted that always outgoing_auth_needed() returns 1 you do > > a request_auth, and always it returns 0 you don't, so I think we can > > embed request_auth() inside outgoing_auth_needed() as it was in patch > > 2/3 and the give a better name to outgoing_auth_needed() which you > > reflect the new behavior. > > I don't think the check and request should be in the same function since > there are two places that need the check but not the request. In that case such function will return after the check not doing any request. -- Gustavo F. Padovan http://profusion.mobi -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
