Hi Sheldon, On Tue, Nov 16, 2010, Sheldon Demario wrote: > --- > TODO | 6 ------ > attrib/gatttool.c | 15 +++++++++++++-- > 2 files changed, 13 insertions(+), 8 deletions(-) In general the patch seems fine, but: > + if (strncmp(opt_sec_level, "medium", 6) == 0) > + sec_level = BT_IO_SEC_MEDIUM; > + else if (strncmp(opt_sec_level, "high", 4) == 0) > + sec_level = BT_IO_SEC_HIGH; > + else > + sec_level = BT_IO_SEC_LOW; Why do you use strncmp instead of strcmp (or even g_str_equal)? I don't think there's any need to map e.g. "mediumfoobar" to BT_IO_SEC_MEDIUM ;) Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
