Hi Johan, * Johan Hedberg <johan.hedberg@xxxxxxxxx> [2010-11-12 18:54:34 +0200]: > Hi Inga, > > On Thu, Nov 11, 2010, Inga Stotland wrote: > > Was there a bug to begin with? :) > > The access to eir_data[1] was always valid due to the check (len < > > EIR_DATA_LENGTH - 1) > > and the fact that eir_data is a buffer of fixed length of EIR_DATA_LENGTH > > (240 bytes). > > On closer inspection it seems you might be right, however it'd be nice > to get some comments from the original patch author about this (were > there e.g. crashes or some valgrind warnings observed or was this just > speculation based on looking at the code). > > Btw, it seems I may need to slow down on my response time to patches so > there's better time for other people to review them too. E.g. both you > and Luiz were a bit late to the game on a couple of recent patches. > Maybe a 24 hour period before I push anything might be good enough? I would say 48h, give more time to people review, in case you spent a whole day off the linux-bluetooth. -- Gustavo F. Padovan http://profusion.mobi -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
