Hi Siarhei, On Thu, Nov 11, 2010, Siarhei Siamashka wrote: > In the case of scale factors calculation optimizations, the inline > assembly code has instructions which update flags register, but > "cc" was not mentioned in the clobber list. When optimizing code, > gcc theoretically is allowed to do a comparison before the inline > assembly block, and a conditional branch after it which would lead > to a problem if the flags register gets clobbered. While this is > apparently not happening in practice with the current versions of > gcc, the clobber list needs to be corrected. > > Regarding the other inline assembly blocks. While most likely it > is actually unnecessary based on quick review, "cc" is also added > there to the clobber list because it should have no impact on > performance in practice. It's kind of cargo cult, but relieves > us from the need to track the potential updates of flags register > in all these places. > --- > sbc/sbc_primitives_mmx.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) Thanks for the patch! It has now been pushed upstream. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
