Hi Dmitriy, On Thu, Nov 11, 2010, Dmitriy Paliy wrote: > +static void *vobject_create(void *user_data) There's no reason for the void * types here. Use specific types instead. > @@ -718,10 +736,13 @@ static void *vobject_pull_open(const char *name, int oflag, mode_t mode, > cb = query_result; > > ret = phonebook_pull(name, pbap->params, cb, pbap); > + > if (ret < 0) > goto fail; No need to add the empty line. > > - return pbap; > + obj = vobject_create(pbap); > + > + return obj; Just do "return vobject_create(pbap);" > + obj = vobject_create(pbap); > + > + return obj; Same here. > + obj = vobject_create(pbap); > + > + return obj; And here. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
