Hi, On Wed, Nov 10, 2010 at 6:07 PM, Gustavo F. Padovan <padovan@xxxxxxxxxxxxxx> wrote: > Hi Waldemar, > > * Waldemar.Rymarkiewicz@xxxxxxxxx <Waldemar.Rymarkiewicz@xxxxxxxxx> [2010-11-10 13:12:53 +0200]: > >> Hi Marcel, >> >> >> + void Disable() >> >> + >> >> + Shudown SAP server and remove the SDP record. >> >> + >> >> + Possible errors: org.bluez.Error.Failed >> > >> >I don't like this. If you have properties then just changing >> >the property should be enough. So a SetProperty is more appropriate. >> >> I see another option to get rid of 'Enabled' property and leave the methods. What would you say on that? > > It's not a good a idea. We have been moving everything we can to a set > property operation instead of a method call. Do that as method is add > unnecessary code to BlueZ once we already have set property there. > >> >> >> + >> >> + void Disconnect(boolean type) >> >> + >> >> + Disconnect SAP client from the server. >> >The 'type' >> >> + parameter indicates disconnection type. >> >> + >> >> + True - gracefull disconnection >> >> + False - immediate disconnection >> >> + >> >> + Possible errors: org.bluez.Error.Failed >> > >> >I don't like this style of method names at all. Using method >> >names like GracefulDisconnect and ImmediateDisconnect would be better. >> >> That's fine. >> >> >However I am not sure we should differentiate here at all. We >> >should always to the graceful disconnect. What will the >> >immediate disconnect bring us? >> >> That's actually intended for testing only. One of PTS test cases expects the tester to trigger immediate disconnect. >> In practce, it is only used when connection to sim card is lost, but this is obviously done internally. > > > So this shouldn't be in the API, no one is going to use it. You can > create something internally for the immediate disconnection that you go > and set manually inside the code. Make sure to comment in the code why > you are adding this there. That can also be a option in some of the > bluetooth config files. Let's see what others think here. Actually this looks a lot like virtual cable unplug that PTS wants to hid, it is just crap that nobody use, so maybe e.g. --enable-pts-bullshit would actually make sense to activate the nonsense that pts wants, well it is still annoying to recompile just to run PTS tests. For hid the virtual cable unplug can be emulate via RemoveDevice, so maybe it make sense to do a immediate disconnect in such case for sap too, but this is still inconvenient since you have to repair after doing it. -- Luiz Augusto von Dentz Computer Engineer -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
