Re: [PATCH] Move gattrib source files to src directory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

> > gattrib related functions will be required during the device creation
> > for GATT enabled devices(BR/EDR and LE). Primary service discovery is
> > a pre-condition to probe the GATT device driver.
> > ---
> >  Makefile.am      |    7 +-
> >  attrib/att.c     |  764 ------------------------------------------------------
> >  attrib/att.h     |  206 ---------------
> >  attrib/gatt.c    |  113 --------
> >  attrib/gatt.h    |   43 ---
> >  attrib/gattrib.c |  535 --------------------------------------
> >  attrib/gattrib.h |   72 -----
> >  src/att.c        |  764 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  src/att.h        |  206 +++++++++++++++
> >  src/gatt.c       |  113 ++++++++
> >  src/gatt.h       |   43 +++
> >  src/gattrib.c    |  535 ++++++++++++++++++++++++++++++++++++++
> >  src/gattrib.h    |   72 +++++
> >  13 files changed, 1736 insertions(+), 1737 deletions(-)
> >  delete mode 100644 attrib/att.c
> >  delete mode 100644 attrib/att.h
> >  delete mode 100644 attrib/gatt.c
> >  delete mode 100644 attrib/gatt.h
> >  delete mode 100644 attrib/gattrib.c
> >  delete mode 100644 attrib/gattrib.h
> >  create mode 100644 src/att.c
> >  create mode 100644 src/att.h
> >  create mode 100644 src/gatt.c
> >  create mode 100644 src/gatt.h
> >  create mode 100644 src/gattrib.c
> >  create mode 100644 src/gattrib.h
> 
> I'll wait a little bit with this one. I agree that the gattrib
> funcionality needs to be available within the core daemon, but does that
> necessarily mean that the source files for need to be in src? It'd be
> good to get some comment from Marcel about this too.

I think that this change is actually bad. Since we have non-recursive
build system, we are not bound to have code under the same directory.

So my advise would be to not do this and just link the attrib/* code
into the bluetoothd.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux