Hi Johan,
>
>Never mind the previous comment I had about this. I checked
>the rest of the tree and it seems this inline convention for
>D-Bus error generating functions is quite common (though imho
>might not be needed at all).
>
>> + if(sim_card_connection_status != SIM_CONNECTED)
>
>Space before (
>
>> +}
>> +
>> +
>> +static GDBusMethodTable dummy_methods[] = {
>
>Remove the other empty line.
>
>> + { "OngoingCall", "b", "", ongoing_call},
>> + { "MaxMessageSize", "u", "", max_msg_size},
>> + { "Disconnect", "", "", disconnect},
>> + { "CardStatus", "u", "", card_status},
>> + { }
>
>> +static GDBusSignalTable dummy_signals[] = {
>> + { "","" },
>> + { }
>> +};
>
>If you have no signals just pass NULL to
>g_dbus_register_interface instead of declaring an (almost)
>empty table. Also, "" isn't a valid value for the signal name.
Thanks again for comments and see attached patch.
/WaldekAttachment:
0004-Sim-Access-Profile-dummy-driver.patch
Description: 0004-Sim-Access-Profile-dummy-driver.patch
