Hi Rafal, On Wed, Oct 13, 2010, Rafal Michalski wrote: > - mce_bt_set = !!(sigvalue & MCE_RADIO_STATE_BLUETOOTH); > + mce_bt_set = sigvalue & MCE_RADIO_STATE_BLUETOOTH ? > + TRUE : FALSE; Ok, that's basically a coding style fix. > - mce_bt_set = radio_states & MCE_RADIO_STATE_BLUETOOTH; > + mce_bt_set = radio_states & MCE_RADIO_STATE_BLUETOOTH ? TRUE : FALSE; And that's a clear bug fix (since there's no guarantee that the binary and results in the value 1 or TRUE). In principle I'd prefer having coding style patches separate from real bug fixes (even for trivial changes), but since these are related I've let it go for now and pushed the patch upstream. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
