Hi, Sorry. My bad. It was never my intention to change src/adapter.c. I've prepared two patches with the same name and of course send the wrong one. Problem with invalid read fix change made in src/sdpd-service.c file. Lukasz 2010/10/6 Johan Hedberg <johan.hedberg@xxxxxxxxx>: > Hi Lukasz, > > On Wed, Oct 06, 2010, Lukasz Pawlik wrote: >> This patch fix problem with reading data from out of the array range in >> function used to create EIR response. > > You'll need to explain in more detail exactly what was wrong with the > old code and how your patch fixes it (and why it is the correct fix). > >> - uint8_t data[240]; >> + uint8_t data[242]; > > Why 242? The core spec defines the EIR data as a 240 byte field. > >> - uuid128_data[SIZEOF_UUID128 - k]) >> + uuid128_data[SIZEOF_UUID128 - 1 - k]) > > This change looks fine (the index of the last byte is sizeof(uuid128) - 1). > > Johan > -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
