On Thu, Sep 30, 2010 at 6:51 PM, Claudio Takahasi
<claudio.takahasi@xxxxxxxxxxxxx> wrote:
> On Thu, Sep 30, 2010 at 11:28 AM, Claudio Takahasi
> <claudio.takahasi@xxxxxxxxxxxxx> wrote:
>> On Thu, Sep 30, 2010 at 4:39 AM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote:
>>> Hi Claudio,
>>>
>>> On Wed, Sep 29, 2010, Claudio Takahasi wrote:
>>>> StartDiscovery() triggers all the process. The adapter type: BR/EDR
>>>> only/LE only or dual mode is hidden from the higher layers.
>>>> So, your suggestion it try to hide all discovery details inside the
>>>> hciops as much as possible?
>>>
>>> That was the idea yes, but I'm not 100% sure that it's the best
>>> approach. Another question is also how do we want to represent this with
>>> the new management interface. Should the kernel do it "all" through a
>>> single request from userspace or should userspace control the separate
>>> BR/EDR and LE discoveries. If it's the former, then having a single
>>> adapter_ops callback makes sense. If it's the later then we should
>>> probably have two separate ones. Either way I now realize that to
>>> implement this with a single callback we'd need to have the HCI event
>>> processing moved over to hciops and that's not something that will
>>> happen very quickly. So maybe it's better to have these as two separate
>>> adapter_ops callbacks for now.
>>>
>>> Johan
>>>
>>
>> Another point is: scanning needs to be disabled "actively", it is not
>> possible to inform a scanning length like inquiry, it is necessary to
>> create a timeout to disable the scanning. Joining inquiry and scanning
>> inside a single adapter_ops callback will be hard to control the
>> discovery procedure "states". So for now, I prefer two separate
>> callbacks due the scanning timeout and HCI events processing.
>>
>> However, for the new management interface, one single request seems to
>> be more appropriate but extra requests will be necessary to setup the
>> scan and inquiry parameters.
>>
>> Claudio
>>
>
> New pull request! Patches rebased and a new hciops callback function
> has been added to export the write LE host supported command.
>
> The following changes since commit 3a8386d428e385d97b95a890623362321a7e3a19:
>
> ÂFix left open socket warning for attribute server (2010-09-30 17:26:55 -0300)
>
> are available in the git repository at:
> Âgit://git.infradead.org/users/cktakahasi/bluez.git for-upstream
>
> Claudio Takahasi (23):
> Â Â ÂAdd LE start and stop scanning
> Â Â ÂRemove RSSI field from the advertising report event
> Â Â ÂDecoding the RSSI parameter from the advertising report event
> Â Â ÂSend Discovering property "FALSE" when the interleave finishes
> Â Â ÂAdd length argument on hciops start discovery function
> Â Â ÂStop inquiry using the length parameter
> Â Â ÂFix remote name resolution for interleave discovery
> Â Â ÂAdd Write LE host supported function
> Â Â ÂSet the LE host supported and disable simultaneous LE and BR/EDR flags
> Â Â ÂAdd extended feature mask constants definition
> Â Â ÂRead the local extended features
> Â Â ÂStop LE scanning when discovery is suspended
> Â Â ÂRename hciops {start, stop}_discovery to {start, stop}_inquiry
> Â Â ÂDon't enter on interleave mode if there isn't active sessions
> Â Â ÂCode cleanup: improving inquiry logic
> Â Â ÂClear the remote device found list in the state transition
> Â Â ÂFix periodic inquiry signals
> Â Â ÂFixing DeviceDisappeared signal
> Â Â ÂPostpone discovery if still resolving names
> Â Â ÂAdd adapter discovery type function
> Â Â ÂDo not send another Discovering TRUE signal if still resolving names
> Â Â ÂForcing periodic inquiry exit
> Â Â ÂFix interleave scanning
>
> Vinicius Costa Gomes (1):
> Â Â ÂAdd BR/EDR LE interleaved discovery
>
> Âlib/hci.c    Â|  29 +++++
> Âlib/hci.h    Â|  17 +++-
> Âlib/hci_lib.h  Â|  Â1 +
> Âplugins/hciops.c | Â 69 +++++++++++-
> Âsrc/adapter.c  Â| Â301 +++++++++++++++++++++++++++++++++++++-----------------
> Âsrc/adapter.h  Â|  38 ++++---
> Âsrc/dbus-hci.c  |  45 +++++++--
> Âsrc/dbus-hci.h  |  Â1 +
> Âsrc/security.c  | Â131 ++++++++++++++----------
> Â9 files changed, 449 insertions(+), 183 deletions(-)
>
The following changes since commit 19c8e310329bb6b369f11501afec9ff4223c2971:
Allow errors to propagate from connection callback (2010-10-04 17:06:49 +0200)
are available in the git repository at:
git://git.infradead.org/users/cktakahasi/bluez.git for-upstream
Claudio Takahasi (23):
Add LE start and stop scanning
Remove RSSI field from the advertising report event
Decoding the RSSI parameter from the advertising report event
Send Discovering property "FALSE" when the interleave finishes
Add length argument on hciops start discovery function
Stop inquiry using the length parameter
Fix remote name resolution for interleave discovery
Add Write LE host supported function
Set the LE host supported and disable simultaneous LE and BR/EDR flags
Add extended feature mask constants definition
Read the local extended features
Stop LE scanning when discovery is suspended
Rename hciops {start, stop}_discovery to {start, stop}_inquiry
Don't enter on interleave mode if there isn't active sessions
Code cleanup: improving inquiry logic
Clear the remote device found list in the state transition
Fix periodic inquiry signals
Fixing DeviceDisappeared signal
Postpone discovery if still resolving names
Add adapter discovery type function
Do not send another Discovering TRUE signal if still resolving names
Forcing periodic inquiry exit
Fix interleave scanning
Vinicius Costa Gomes (1):
Add BR/EDR LE interleaved discovery
lib/hci.c | 29 +++++
lib/hci.h | 17 +++-
lib/hci_lib.h | 1 +
plugins/hciops.c | 69 +++++++++++-
src/adapter.c | 301 +++++++++++++++++++++++++++++++++++++-----------------
src/adapter.h | 38 ++++---
src/dbus-hci.c | 45 +++++++--
src/dbus-hci.h | 1 +
src/security.c | 131 ++++++++++++++----------
9 files changed, 449 insertions(+), 183 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
