Hi Rafal, On Thu, Sep 30, 2010, Rafal Michalski wrote: > Expression (sigvalue & MCE_RADIO_STATE_BLUETOOTH) is invalid because it makes > wrong assumption about that it evaluates to TRUE, when bit > MCE_RADIO_STATE_BLUETOOTH is set. In this case, assignment > mce_bt_set = (sigvalue & MCE_RADIO_STATE_BLUETOOTH) makes that gboolean > "mce_bt_set" receives value equal 8 instead of TRUE (equal 1). So condition in > "if (mce_bt_set == powered)" statement will never evaluate to true because > gboolean "powered" receives only TRUE (equal 1) or FALSE (equal 0) value. > We should remember that gboolean type is not bool type in C++ sense. > It's simply typedef of gint (int), so assignmnet: > mce_bt_set = (sigvalue & MCE_RADIO_STATE_BLUETOOTH) is valid for compiler but > in our case it makes a bug. So normalization (double negation) in assignment: > mce_bt_set = !!(sigvalue & MCE_RADIO_STATE_BLUETOOTH) preserves that > "mce_bt_set" will receive only TRUE or FALSE value. > --- > plugins/maemo6.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks. The patch has been pushed upstream with a much simplified commit message (the above is really quite complicated to read compared to the simplicity of the actual fix). Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
