Hi, Patch is ok but just one comment. See below. On Wed, Sep 29, 2010 at 01:12:39PM +0200, haijun liu wrote: > > Replace hard code of configuration continuation flag with self-comment macro. > > - if (flags & 0x0001) { > + if (flags & L2CAP_CONF_FLAG_CONT) { > /* Incomplete config. Send empty response. */ > l2cap_send_cmd(conn, cmd->ident, L2CAP_CONF_RSP, > l2cap_build_conf_rsp(sk, rsp, Maybe you could use L2CAP_CONF_FLAG_CONT also in l2cap_build_conf_rsp()? -- Ville -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html