Hi, On Tue, Sep 21, 2010, Jose Antonio Santos Cadenas wrote: > Declaration, defines and struct definitions are moved to the begining > of the file. Just for make the code more readable. > --- > health/mcap_sync.c | 86 +++++++++++++++++++++++++-------------------------- > 1 files changed, 42 insertions(+), 44 deletions(-) Thanks, the patch is now upstream. While you're at it, please also remove any unnecessary forward declarations, like these: > +static void proc_sync_cap_req(struct mcap_mcl *mcl, uint8_t *cmd, uint32_t len); > +static void proc_sync_set_req(struct mcap_mcl *mcl, uint8_t *cmd, uint32_t len); > +static void proc_sync_cap_rsp(struct mcap_mcl *mcl, uint8_t *cmd, uint32_t len); > +static void proc_sync_set_rsp(struct mcap_mcl *mcl, uint8_t *cmd, uint32_t len); > +static void proc_sync_info_ind(struct mcap_mcl *mcl, uint8_t *cmd, uint32_t len); Only in very rare cases are forward declarations needed. Whenever possible order the functions so that the dependencies of a function are defined above the function in the C file. > +static gboolean sync_send_indication(gpointer user_data); > +static gboolean proc_sync_set_req_phase2(gpointer user_data); Same here. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
