Hi Suraj, >-----Original Message----- >From: Suraj Sumangala [mailto:suraj@xxxxxxxxxxx] >Sent: Tuesday, September 07, 2010 11:28 AM >Hi Waldek, > >On 9/7/2010 2:06 PM, Waldemar.Rymarkiewicz@xxxxxxxxx wrote: >> Hi Suraj, >> >>> From: Suraj Sumangala [mailto:suraj@xxxxxxxxxxx] >>> Sent: Tuesday, September 07, 2010 8:03 AM >> >>> + >>> + void Disconnect(string type) >>> + >>> + This initiates a SAP disconnection from >>> SAP server. >>> + >>> + The type parameter specifies the type >>> of disconnection. >>> + >>> + "Graceful" -> lets the SAP client initiate a >>> + garceful disconnection. >>> + >>> + "Immediate" -> disconnects the connection >>> + immediately from the server. >>> + >> >> In my view, the disconnection should be initiates by the sap >server, not by the agent. In a typical use case the agent will >communicate sim state change (card removed or not accessible) >to sap server. Based on that, the sap server should make a >decision whether disconnect or not. What's more the disconnect >procedure is defined in the SAP spec, and would be nice to >keep all those procedures in the sap server, not in the agent >which will be specific for a sim provider. Therefore, I would >remove this method call from the api. I would add the >Disconnect signal instead. >> >> Signal: >> Disconnect() >> This signal will be send when SAP connectionis >successfully removed. >> >> In case of graceful disconnection sap server sends signal >to the agent REQUEST(disconnect) and wait till SIM free its >stuff and send back RESPONSE(disconnect). In case of >immediate disconnection sap server will send Disconnect() >signal to the agent. > >Ok, In which all situations should the SAP server decide that >the SAP connection has to be disconnected (you have mentioned >Sim Status change as one candidate)? >Also, based on what should the server decide to initiate a >"Graceful" or "Immediate" disconnection? Well, I thought this over and in case of sim state change sap should propagate this change to sap client, not disconnect. The only place when sap sever uses immediate disconnection imho are problems on the connection with agent (dbus errors), and the graceful disconnection should be used in case when the user want to stop sap server. In this point Enable/Disable methods are missing to let the User chance to stop/run sap server. /Waldek -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
