Johan, >From: Johan Hedberg [mailto:johan.hedberg@xxxxxxxxx] >Sent: Friday, August 27, 2010 2:45 PM >So how well have you tested the patches? I.e. how confident >are you that you're not introducing any regressions? Scenarios >that would need to be tested before an upstream merge are (and >I'm probably forgetting several of them): > >- legacy pairing acceptor & initiator >- security mode 3 acceptor & initiator >- ssp acceptor & initiator >- renewed link key handling for both debug and normal keys >- security level upgrading (i.e. connect first to a low security socket > and then over the same ACL to a higher security socket) >- complete and partial failure scenarios for all of the above I've completed more tests on the patches and didn't faced any problems do far. Legacy paring, ssp, sec mode 3, refresh existing keys and security upgrading have finished with success. I did the tests for bluez as initiator and again when bluez was an acceptor. All tests were done against different controllers CSR (1.1, 2.0, 2.1), Broadcom (2.0, 2.1), ST-Ericsson (2.1). I also tried different combinations of the controllers in the same use case. So, I'm pretty sure that it will not introduce any regression. >Additionally all these test should be done against several >different controllers due to differences in HCI interface >behavior (event ordering, error codes, etc). In that list I'd >include at least one CSR, and one Broadcom adapter and any >other adapters from other manufacturers that you can get hold of. > >So how many of these tests do you already have covered? I'm >not very comfortable with pushing the patches upstream before >most of the above scenarios have been tested and verified not >to introduce any regressions. > Aditionally, we plan to bring this to the UPF and it would be appreciated if also other would have that possibility for regression testing. If it comes to interaction with the agent I would do this in a seperate patch which will contain a new property when 16 digit pin code is required. I attached slightly updated patches. Regards, /Waldek
Attachment:
0001-BT_SECURITY_HIGH-requires-16-digit-pin-code.patch
Description: 0001-BT_SECURITY_HIGH-requires-16-digit-pin-code.patch
Attachment:
0001-Bluetooth-BT_SECURITY_HIGH-requires-16-digit-pin-cod.patch
Description: 0001-Bluetooth-BT_SECURITY_HIGH-requires-16-digit-pin-cod.patch
