Re: [PATCH 1/1] Bluetooth: Add socket option definitions for AMP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




David -

On Wed, 18 Aug 2010, David Vrabel wrote:

Mat Martineau wrote:
This adds a new BT_AMP socket option to control the use of AMP channels.
It is for use with the SOL_BLUETOOTH option level on L2CAP sockets.

Available option values are defined as:

[lots of nice documentation]

Why is none of this documentation in the code?

I believe we also agreed that this policy could be changed at any point
in the life time of the channel so this should be documented as well.

+#define BT_AMP		8

Suggest BT_AMP_POLICY, BT_AMP_POLICY_REQUIRE_BR_EDR etc.  Just in case
there are other AMP related socket options in the future.

+#define BT_AMP_REQUIRE_BR_EDR	0
+#define BT_AMP_PREFER_AMP	1
+#define BT_AMP_PREFER_BR_EDR	2

Thanks for the helpful feedback - I'll add the documentation, adjust the names, and repost.

--
Mat Martineau
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux