Hi Lucasz,
On Mon, Aug 16, 2010, Lukasz Pawlik wrote:
> Previously in a phonebook pull request ADR was filled with six
> semicolons when contact address entry was empty in phonebook. This
> patch fixes this problem. Address is send as an empty string.
> ---
> plugins/vcard.c | 25 +++++++++++++++++++++++++
> 1 files changed, 25 insertions(+), 0 deletions(-)
Thanks for the patch, but it'll need some coding style cleanup before
going upstream:
> +static gboolean address_fields_present(struct phonebook_contact * contact)
No space after *
> + if (contact->country && strlen(contact->country))
> + return TRUE;
> +
The last line isn't really empty byt has an extra tab. Please remove it.
> + if (address_fields_present(contact) == FALSE) {
> + vcard_printf(vcards, "ADR:");
> + return;
There's an extra tab at the end of the line. Please remove it.
> + }
> +
Same here.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
