On 8/10/2010 2:16 PM, Johan Hedberg wrote:
+static inline int ignore_device(struct hci_dev_info *di) +{ + return hci_test_bit(HCI_RAW,&di->flags) || di->type>> 4 != HCI_BREDR; +}Since this is hci_lib.h (something I didn't realize in the previous review) the function should follow the same namespace as all other functions in the header file, i.e. hci_*. However, does the function really need to be exported in this public library header file, i.e. isn't there some private header file that could be used instead?
It looks like src/hcid.h fits the bill, although the modified hcid.h will need to include the hci headers to have the appropriate defines... Modified patch coming up.
Thanks, David -- David Scherba Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
