Hi Marcel, On Tue, Aug 10, 2010 at 4:07 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > Hi Andrei, > >> From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx> >> >> Patch adds new socket option to enter active state when sending >> data. Modified version of Fabien Chevalier patch (Sep/2008). >> Discussions: >> http://www.spinics.net/lists/bluez-devel/msg00567.html >> http://www.spinics.net/lists/linux-bluetooth/msg03765.html >> >> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx> >> --- >> include/net/bluetooth/hci_core.h | 1 + >> include/net/bluetooth/l2cap.h | 1 + >> net/bluetooth/hci_conn.c | 7 ++++++- >> net/bluetooth/l2cap.c | 3 +++ >> 4 files changed, 11 insertions(+), 1 deletions(-) >> >> diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h >> index e42f6ed..477a492 100644 >> --- a/include/net/bluetooth/hci_core.h >> +++ b/include/net/bluetooth/hci_core.h >> @@ -178,6 +178,7 @@ struct hci_conn { >> __u8 auth_type; >> __u8 sec_level; >> __u8 power_save; >> + __u8 force_active; >> __u16 disc_timeout; >> unsigned long pend; >> >> diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h >> index 7c695bf..0a8ac4c 100644 >> --- a/include/net/bluetooth/l2cap.h >> +++ b/include/net/bluetooth/l2cap.h >> @@ -57,6 +57,7 @@ struct l2cap_options { >> __u8 mode; >> __u8 fcs; >> __u8 max_tx; >> + __u8 force_active; >> __u16 txwin_size; >> }; > > this is a clear NAK. You are breaking API and ABI compatibility with > this change. > > Also don't overload the l2cap_options, create a new one. I have sent new patch. Are other comments from 2008 patch still valid? Like using SOL_BLUETOOTH and make sockopt for RFCOMM as well. Regards, Andrei -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
