Hi Inga, The patches are starting to look pretty good. A couple more coding style issues though (in this and a few consequtive emails): On Tue, Aug 03, 2010, Inga Stotland wrote: > + ptr[1] = (truncated) ? EIR_UUID16_SOME : EIR_UUID16_ALL; Another patch in your patch set "fixes" this and removes the parenthesis around truncated. Could you just fix it in this patch itself. In general patches with fixes to other patches that aren't yet upstream should be avoided by redoing the the first patch that caused the need for a fix to begin with. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html