Re: [PATCH 4/6] Fix in logic to write EIR when SDP records are changed.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Inga,

On Sat, Jul 31, 2010, Inga Stotland wrote:
> Whenver SDP service record is added/deleted/modified check for whether 
> class of device needs to be updated as well. If the update is 
> needed, proceed as before and new EIR will be written subsequently. 
> If the class of device is already present, just update EIR and return.
> ---
>  src/adapter.c |   14 ++++++++++----
>  1 files changed, 10 insertions(+), 4 deletions(-)

A few minor coding style issues

> -	/* If we already have the CoD we want or the cache is enabled or an
> -	 * existing CoD write is in progress just bail out */
> -	if (adapter->current_cod == adapter->wanted_cod ||
> -			adapter->cache_enable || adapter->pending_cod)
> +	/* If the cache is enabled or an existing CoD write is in progress
> +	 * just bail out */
> +	if(adapter->cache_enable || adapter->pending_cod)

Missing space beteween if and (

>  		return 0;

Add an empty line here.

> +	/* If we already have the CoD we want, update EIR and return */
> +	if (adapter->current_cod == adapter->wanted_cod) {
> +		update_ext_inquiry_response(adapter);
> +		return 0;
> +	}

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux