Hi Ville,
* Ville Tervo <ville.tervo@xxxxxxxxx> [2010-07-30 16:13:00 +0300]:
> Hi,
>
> On 07/29/2010 09:00 PM, ext Gustavo F. Padovan wrote:
> >From: Gustavo F. Padovan<padovan@xxxxxxxxxxxxxx>
> >
> >If the remote side doesn't support Enhanced Retransmission Mode neither
> >Streaming Mode, we shall not send the RFC option.
> >Some devices that only supports Basic Mode do not understanding the RFC
> >option. This patch fix the regression found with that devices.
>
>
> Yes this is better. After some research i found out that quite many
> old devices are not handling properly unknown options.
Nice, we can put this upstream, do you agree?
>
> However I found another regression. And this kind of patch is needed
> also. Otherwise the info rsp code is reading feat_mask from failed
> response (and does invalid memory access).
>
>
> diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
> index 0f34e12..1e174a4 100644
> --- a/net/bluetooth/l2cap.c
> +++ b/net/bluetooth/l2cap.c
> @@ -3348,6 +3348,13 @@ static inline int
> l2cap_information_rsp(struct l2cap_conn *conn, struct l2cap_cm
>
> del_timer(&conn->info_timer);
>
> + if (result != L2CAP_IR_SUCCESS) {
> + conn->info_state |= L2CAP_INFO_FEAT_MASK_REQ_DONE;
> + conn->info_ident = 0;
> + l2cap_conn_start(conn);
> + return 0;
> + }
> +
> if (type == L2CAP_IT_FEAT_MASK) {
> conn->feat_mask = get_unaligned_le32(rsp->data);
>
Ack. Send a proper GIT patch then we can push this fix.
--
Gustavo F. Padovan
http://padovan.org
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
