Hi Johan, Johan Hedberg wrote: > Hi, > > On Mon, Jul 26, 2010, Zhenhua Zhang wrote: >> Avoid the memory leak of server_data. >> --- >> gdbus/watch.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/gdbus/watch.c b/gdbus/watch.c >> index 1d479fa..29f23e2 100644 >> --- a/gdbus/watch.c >> +++ b/gdbus/watch.c >> @@ -533,7 +533,7 @@ static void check_service(DBusConnection >> *connection, const char *name, goto done; } >> >> - dbus_pending_call_set_notify(call, service_reply, data, NULL); >> + dbus_pending_call_set_notify(call, service_reply, data, g_free); >> >> dbus_pending_call_unref(call); > > Thanks for the updated patch. It has now been pushed both to bluez and > obexd upstream trees with a fixed commit message (e.g. your summary > line was not truthful anymore since the data isn't being freed in > service_reply but by libdbus itself. > > Johan Thanks. Will pay attention to the commit title next time. Regards, Zhenhua -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
