Re: [PATCH][RFC] Fix SDP resolving segfault

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Luiz,
I don't really understand the need for these changes, but admitedly the
function does have issues since it first checks for !ctxt->session and
then later for ctxt->session even though at that point it's already
guaranteed that ctxt->session is not NULL.
Yep, I suspect it is something else too, there doesn't seems to be a
call to bt_cancel_discovery in the last trace sent to the list, but
the check for ctxt->session there seems buggy, we should always remove
the context doesn't matter if it is connected or not.
I think the problem is that the watch function is still registered even though we no longer have a session... maybe this doesn't make sense, no way we have a context and don't have a session.

Still if there's no session the context never gets released.

@Manuel: Does valgrind give you a nice bracktrace when it bluetoothd segfaults?

Normally I use something like this:

sudo valgrind --trace-children=yes ./bluetoothd -dn
Check the other email, I made it by running bluetoothd -ndt (this is a feature I commited, which uses instrumentation-functions from gcc, a really nice feature).

Manuel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux