Hi!
I've realized that previous solution was little conflicted with PBAP spec:)
Now I've found real source of the problem with generating VCARDS( for empty N: parameter no unnecessary characters should be inserted - and in current code there was 4 semicolons in that place)
For BH-903 it works great - now I need to make some testing with various carkits.
If everything will work as expected then final patch will be available tommorow morning.
BR,
Radek
________________________________________
From: ext Marcel Holtmann [marcel@xxxxxxxxxxxx]
Sent: Wednesday, July 07, 2010 11:25 PM
To: Radoslaw Jablonski (EXT-Comarch/Helsinki)
Cc: linux-bluetooth@xxxxxxxxxxxxxxx
Subject: RE: [PATCH] Added empty VCARD N: parameter handling
Hi,
> I've made necessary changes to the code. Now it should look much better:)
> New version of patch is inserted below.
and please use git send-email. Otherwise we can't apply it with git am.
> From 45dfcf8f9dfacd8937a1a1d14146bd0da04eca25 Mon Sep 17 00:00:00 2001
> From: Radoslaw Jablonski <ext-jablonski.radoslaw@xxxxxxxxx>
> Date: Wed, 7 Jul 2010 17:18:31 +0300
> Subject: [PATCH] Added empty VCARD N: parameter handling
>
> Some of the devices are expecting that N: parameter in VCARD is always filled (by example Nokia BH-903)
> When this field is empty (N:;;;;) then list of dialed/incoming calls on carkit is useless - carkit then shows only blank lines and it's impossible to determine who made call ( phone number are invisible too in this case)
>
> If none of the contact fields is available, then setting telephone number as the first attribute for "N:" parameter.
> Carkit will see that number as contact name - it is only used in case when none of more detailed contact information is available on the phone.
> ---
> plugins/vcard.c | 21 +++++++++++++++++++++
> 1 files changed, 21 insertions(+), 0 deletions(-)
>
> diff --git a/plugins/vcard.c b/plugins/vcard.c
> index 5948a4a..ab1349c 100644
> --- a/plugins/vcard.c
> +++ b/plugins/vcard.c
> @@ -123,6 +123,20 @@ static void add_slash(char *dest, const char *src, int len_max, int len)
> return;
> }
>
> +/* checks if there is at least one present contact field with personal data */
> +static gboolean contact_fields_present( struct phonebook_contact * contact)
> +{
It is (struct ... contact *contact). See other code for proper placement
of whitespaces.
> + if ((contact->family && strlen(contact->family)) ||
> + (contact->given && strlen(contact->given)) ||
> + (contact->additional && strlen(contact->additional)) ||
> + (contact->prefix && strlen(contact->prefix)) ||
> + (contact->suffix && strlen(contact->suffix)))
> + return TRUE;
> +
> + /* none of the personal data fields is present*/
> + return FALSE;
> +}
if (contact->family && strlen(contact->family) > 0)
return TRUE;
if (contact->given && strlen(contact->given) > 0)
return TRUE;
...
return FALSE;
That is a more readable version of this function.
> +
> static void vcard_printf_begin(GString *vcards, uint8_t format)
> {
> vcard_printf(vcards, "BEGIN:VCARD");
> @@ -136,6 +150,13 @@ static void vcard_printf_begin(GString *vcards, uint8_t format)
> static void vcard_printf_name(GString *vcards,
> struct phonebook_contact *contact)
> {
> + if (contact_fields_present(contact) == FALSE) {
> + /* if all fields are empty we're using first phone number as name */
> + struct phonebook_number *number = contact->numbers->data;
> + vcard_printf(vcards, "N:%s;;;;", number->tel);
> + return;
> + }
> +
> vcard_printf(vcards, "N:%s;%s;%s;%s;%s", contact->family,
> contact->given, contact->additional,
> contact->prefix, contact->suffix);
Regards
Marcel--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
