[PATCH] compat: Fix panic caused by NULL pointer derefence in rtnl_fill_ifinfo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



get stats netdev ops is blindy called for older kernels (< 2.6.29) and
so assigning a NULL pointer from netdev_attach_ops causes a NULL pointer
dereference.

By default, netdev alloc provides an internal stats reference. So fill
this only if ndo_get_stats is defined.

Signed-off-by: Rajkumar Manoharan <rmanoharan@xxxxxxxxxxx>
---
 compat/compat-2.6.29.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/compat/compat-2.6.29.c b/compat/compat-2.6.29.c
index f94aed8..2e7e623 100644
--- a/compat/compat-2.6.29.c
+++ b/compat/compat-2.6.29.c
@@ -35,7 +35,8 @@ void netdev_attach_ops(struct net_device *dev,
 	dev->change_mtu = ops->ndo_change_mtu;
 	dev->set_mac_address = ops->ndo_set_mac_address;
 	dev->tx_timeout = ops->ndo_tx_timeout;
-	dev->get_stats = ops->ndo_get_stats;
+	if (ops->ndo_get_stats)
+		dev->get_stats = ops->ndo_get_stats;
 	dev->vlan_rx_register = ops->ndo_vlan_rx_register;
 	dev->vlan_rx_add_vid = ops->ndo_vlan_rx_add_vid;
 	dev->vlan_rx_kill_vid = ops->ndo_vlan_rx_kill_vid;
-- 
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux