Am 05.05.2010 17:02, schrieb Stefan Seyfried:
I have one questions about the code from a cursory look (hint: sending the patch inline would help commenting on it)
Alright, I'll know for the next time.
* where does the 249 in "char name[249];" come from? Is it from the BT spec? Or from somewhere else? A comment in the code might help. (If this is a number from the spec that is used all over the same code file and explained elsewhere, this question is obviously moot)
I took this part of the patch over from tools/hciconfig.c:433 and indeed I think the fact that a device name may be up to 248 characters long is part of the BT spec: <http://www.palowireless.com/infotooth/tutorial/k1_gap.asp#Bluetooth%20Parameter%20Representation>
Then it would probably good if you could send the patch against current git (even if it still applies cleanly) and in a format that "git am" can process directly. That makes it very easy for the maintainers to apply the code and in the same run makes sure you get proper attribution for your contribution ;)
Thanks again. I'd like to get some more feedback for the current patch and will then repost it in the desired format.
BTW, I'll be on vacation from May 7th to 14th, so please excuse if I reply with some days delay.
-- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
