Hi Santiago, * Santiago Carot-Nemesio <sancane@xxxxxxxxx> [2010-05-04 10:43:15 +0200]: > This patch enables MCAP in BlueZ. > Current implementation provides support for standard op. codes. Clock > Synchronization protocol is not yet supported. > --- > Makefile.am | 11 +- > acinclude.m4 | 6 + > mcap/mcap.c | 2146 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > mcap/mcap.h | 176 +++++ > mcap/mcap_lib.h | 162 +++++ > 5 files changed, 2500 insertions(+), 1 deletions(-) > create mode 100644 mcap/mcap.c > create mode 100644 mcap/mcap.h > create mode 100644 mcap/mcap_lib.h 2500+ lines is too big for review. MCAP is way complicated to understand completely. I suggest you to split this patch and send smaller ones for each feature of MCAP you implement, then we can review each piece and not at once. Also a MCAP test tool would be interesting to help on the review/merge/qualification process. Do you guys have one? Or are you planning to do one? -- Gustavo F. Padovan http://padovan.org -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
