Hi,
On Wed, Apr 28, 2010, Elvis Pfutzenreuter wrote:
> +sdp_list_t *adapter_service_list(struct btd_adapter *adapter)
> +{
> + return adapter->services;
> +}
To make this consistent with other exported adapter functions please
call it adapter_get_services().
> + for (; adapters; adapters = adapters->next) {
> + adapter_get_address(adapters->data, &bdaddr);
> +
> + if (bacmp(src, BDADDR_ANY) == 0 || bacmp(src, &bdaddr) == 0)
> + update_adapter_svclass_list(adapters->data);
> + }
I think it'd be good to make it explicit which type of objects are part
of the list, so add to the beginning of the loop:
struct btd_adapter *adapter = adapters->data;
Other than those issues the patch looks ok to me.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
