Hi Dave, > > * Dan Carpenter <error27@xxxxxxxxx> [2010-04-26 13:36:27 +0200]: > > > >> l2cap_create_connless_pdu() can sometimes return ERR_PTR(-ENOMEM) or > >> ERR_PTR(-EFAULT). > >> > >> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > >> --- > >> In v2 I wrote the patch on top of Gustavo Padovon's devel tree > > This is the kind of bug that could cause a crash if the path actually > executes. > > Therefore it tires me that that submitter was told to regenerate this > patch against some devel tree that is -next bound, when in fact this > is the kind of fix that warrants inclusion right now into net-2.6 > > Marcel, please do whatever magic you need to so I can get this into > Linus's tree as I did the rest of the ERR_PTR() fixes from Dan already. > No reason to treat Bluetooth special and defer these fixes to -next. my bad here. I looked at the patch and thought it was only an issue inside the development tree. So was letting Gustavo sort this out. You are 100% right, this needs to be fixed right away. If you wanna take this directly, then Acked-by: Marcel Holtmann <marcel@xxxxxxxxxxxx> Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html