Hi Luiz, On Tue, Mar 02, 2010, Luiz Augusto von Dentz wrote: > Data notiated in a session should be reset once disconnected, to fix > this a new structure is introduced called headset_session is > introduced to hold the session data which is freed when disconnected. In general the idea of the patch is good, but there are a few things that need some further thinking. First of all could we just call a "session" what the HFP spec calls it, i.e. a Service Level Connection, e.g. hs->slc? Or do you have some better suggestion? Secondly you need to be careful when doing one-to-one replacements of existing hs->foo statements with hs->session->foo statements. What if hs->session is NULL? Are there some valid use cases when a function that can access hs->session could get called while hs->session is NULL? Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
