Hi Bastien,
On Sun, Feb 21, 2010, Bastien Nocera wrote:
> The first patch fixes a few typos.
Yep, looks good and I've pushed it upstream.
> The second one requires the openobex patches I posted to the list, but
> should fail gracefully if the support does not exist.
This patch has some issues:
> + /* Setup low-level USB */
> + if (!gw_obex_transport_setup_usb(&handle)) {
> + debug("gw_obex_transport_setup_usb() failed, no USB support?\n");
> + return NULL;
> + }
You forget to set *error before returning NULL here.
> + /* Do the transport connection */
> + if (OBEX_InterfaceConnect(handle, iface) < 0) {
> + debug("Could not connect to USB device '%s'\n", dev);
> + if (error)
> + *error = GW_OBEX_ERROR_NO_SERVICE;
> + return NULL;
> + }
This looks like a memory leak since you don't do the same cleanup of ctx->mutex
and ctx as you do in the other failure cases. Maybe the function could use a
"fail" label where you jump to for cleanup tasks?
Besides those issues the patch seems ok'ish.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
