On Tue, 19 Jan 2010, Bastien Nocera wrote: > On Mon, 2010-01-18 at 23:29 -0800, Marcel Holtmann wrote: > > Hi Bastien, > > > > > Here's a patch to do the Bluetooth Wacom tablet's mode setting in the > > > kernel. In the past, it was done in a patch in bluetootd. > > > > > > The first patch is probably completely wrong. Right now, > > > hid_output_raw_report is done on the intr socket, instead of the ctrl > > > socket. If it's correct to do it on the intr socket, we'd need to add > > > some API as a way to select the ctrl socket instead for use in that > > > driver. > > > > actually the interrupt should be incoming only. So moving the raw output > > to the control channel seems fine to. Any reason why it is on the > > interrupt channel in the first place? > > The patch was written by Jiri and tested by Brian. Not sure what sort of > device Brian tested this with... Hmm, that's right, ctrl pipe would make much more sense (and this is what we do in USB driver as well). I used intr pipe by mistake, but it seems that it made things work for Brian anyway, which is quite puzzling. -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
