Am Mittwoch, 11. November 2009 21:18:39 schrieb Marcel Holtmann: > > I'm looking at btusb_disconnect(), for example. It's one of the few BT > > drivers that seem to use workqueues, and I'm not seeing a > > cancel_work_sync() in the disconnect routine - but maybe the > > btusb_close() routine is called indirectly some way that I just don't > > see. > > so the btusb_close() should be called before btusb_destruct() and the > destruct() callback is only when the last reference count gets dropped > and we do have to free the memory. So it seems we are doing something > wrong in btusb_close(). The close() callback is triggered via > hci_unregister_dev() from btusb_disconnect(). > > As it seems the btusb_close() only cancels the work workqueue and not > the waker workqueue. Could that be the problem. Yes, btusb_close() needs to cancel the waker workqueue, too. In addition, in order to avoid a memory leak it must call usb_scuttle_anchored_urbs(&data->deferred) to make sure any deferred data is destroyed. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
