On Fri, Nov 06, 2009, Bastien Nocera wrote: > > I don't really see the point of this patch. What's the benefit of > > returning "OK" instead of "ERROR" in this case, especially since the > > added command handler doesn't do anything? As far as I see returning > > "ERROR" is the right behavior for us when we encounter a command which > > we don't understand (there are also no other side effects on our side > > when we send an error, i.e. the connection is allowed proceed normally). > > Nobody likes errors showing up in their /var/log/messages. In any case, > that was a minimal patch to avoid that. If that's the main issue here I'd rather just change the error() into a debug() in the code. You'll get much more than just one message like that when connecting e.g. to a CSR based headset since they use lots of vendor-specific AT commands. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
