Hi Marcel,
On Tue, Sep 29, 2009 at 1:55 AM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
> Hi Gustavo,
>
>> ERTM entity need to handle state vars, timers and counters to send and
>> receive I-frames. We initialize all of them to the default values here.
>
> while this is a good idea. Where is the justification for pushing this
> after the merge window?
These patches are bug fixes and implementations of missing parts of ERTM spec.
For instance, they enable ERTM to transmit in a full duplex among other things.
Also, ERTM isn't enabled on L2CAP, so we aren't introducing any regressions and
ASAP we put this code on mainline more feedback we can get from
possible testers.
Should I put this on the commit message?
>
>> Signed-off-by: Gustavo F. Padovan <gustavo@xxxxxxxxxxxxxxxxx>
>> ---
>> net/bluetooth/l2cap.c | 53 ++++++++++++++++++++++++++++++++----------------
>> 1 files changed, 35 insertions(+), 18 deletions(-)
>>
>> diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
>> index 9d586fb..3f9d74b 100644
>> --- a/net/bluetooth/l2cap.c
>> +++ b/net/bluetooth/l2cap.c
>> @@ -2169,6 +2169,20 @@ static void l2cap_add_conf_opt(void **ptr, u8 type, u8 len, unsigned long val)
>> *ptr += L2CAP_CONF_OPT_SIZE + len;
>> }
>>
>> +static inline void l2cap_ertm_init(struct sock *sk) {
>> + l2cap_pi(sk)->expected_ack_seq = 0;
>
> Coding style! The { belong on the next line.
Sorry, :(
>
> Regards
>
> Marcel
>
>
>
--
Gustavo F. Padovan
http://padovan.org
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
