Hi Gustavo,
> pi->conn_state is the right place to set states
>
> Signed-off-by: Gustavo F. Padovan <gustavo@xxxxxxxxxxxxxxxxx>
> ---
> net/bluetooth/l2cap.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
> index 3f9d74b..658e27c 100644
> --- a/net/bluetooth/l2cap.c
> +++ b/net/bluetooth/l2cap.c
> @@ -3433,7 +3433,7 @@ static inline int l2cap_data_channel_sframe(struct sock *sk, u16 rx_control, str
> } else if (rx_control & L2CAP_CTRL_FINAL) {
> if ((pi->conn_state & L2CAP_CONN_SREJ_ACT) &&
> pi->srej_save_reqseq == tx_seq)
> - pi->srej_save_reqseq &= ~L2CAP_CONN_SREJ_ACT;
> + pi->conn_state &= ~L2CAP_CONN_SREJ_ACT;
> else
> l2cap_retransmit_frame(sk, tx_seq);
> }
clearly a bug, but the commit message is not enough. Describe it in
plain English and not some cryptic way. The patch is easier to
understand the commit message. It should be the other way around.
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
