Hi Bastien,
Thanks for finding your time for review.
2009/9/18, Bastien Nocera <hadess@xxxxxxxxxx>:
> Don't use statics, add those to a ps3 specific struct.
This function is ps3remote_event which supposed to be use for ps3remote only,
also the driver assumes only single ps3remote device per bluez instance.
I just copied semantic from ps3remote_decode function, where also 2
statics are used. Though I can move them all to input structure.
Should I?
> > + g_timer_start(((struct fake_hid *)fake->priv)->timer);
>
>
> Why do you start the timer unconditionally, instead of just when using
> the HOME key?
>
Because this statement is to reset event timer, which causes remote to
be disconnected on idle. Each key-press resets the timer
unconditionally. g_timer_start is recommended to use instead of
g_timer_reset since they do the same thing and reset will be
deprecated (I guess).
Regards,
--
Looking forward to reading yours.
Ruslan N. Marchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
