Hi Marcel, On Tue, Sep 15, 2009, Marcel Holtmann wrote: > what are we gaining from doing it like this? I really don't see the > benefit of doing it. Someone please explain it to me. It does add more > code than it deletes. It's about avoiding special-casing the Introspect method and using the framework that gdbus already has for method callbacks. This feels like a cleaner approach to me and with the two refactoring tasks I suggested I suspect we'd also be reducing the total line count (the current patch adds 15 lines to the total but there's something like 15-20 new lines in it that unnecessarily duplicate exsiting code). Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html