Hi Marcel,
On Mon, Aug 24, 2009 at 3:40 PM, Marcel Holtmann<marcel@xxxxxxxxxxxx> wrote:
> Hi Luiz,
>
>> It is just me or hci_conn_enter_active_mode will never do what its
>> name suggests. This check will always succeed:
>>
>> if (conn->mode != HCI_CM_SNIFF || !conn->power_save)
>> goto timer;
>
> so conn->power_save is used to disable automatic sniff mode for incoming
> connections. Mainly HID since they manager it by themselves.
Hmm, but this seems to be done for any device regardless of its type.
So for example we start sending/receiving data to a headset it will
triggers hci_conn_enter_active_mode which I thought would exit sniff
mode, right? (yep, I have seem some headset that doesn't leave sniff
mode by their own).
>> But in hci_mode_change_evt whatever mode different than HCI_CM_ACTIVE
>> reset power_save to zero:
>>
>>
>> if (!test_and_clear_bit(HCI_CONN_MODE_CHANGE_PEND, &conn->pend)) {
>> if (conn->mode == HCI_CM_ACTIVE)
>> conn->power_save = 1;
>> else
>> conn->power_save = 0;
>> }
>
> And again, we are not setting the sniff mode. We disable automatic sniff
> mode feature.
It really seems the opposite, like we were disabling the automatic
active mode since this make us to always hit goto timer; while in
sniff mode. Perhaps this is meant for when remote device has been
controlling modes, which sound strange to me since hci_mode_change_evt
is called even when the we actively change the mode, right?
(hci_conn_idle does that)
--
Luiz Augusto von Dentz
Engenheiro de Computação
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
