Hi,
2009/8/16 Johan Hedberg <johan.hedberg@xxxxxxxxx>:
> Hi,
>
> There are a few issues with this patch:
>
> On Sat, Aug 15, 2009, João Paulo Rechi Vita wrote:
>> if (!interface) {
>> - if (dev->sink && avdtp_is_connected(&dev->src, &dev->dst))
>> + if (dev->source && avdtp_is_connected(&dev->src, &dev->dst))
>> + return TYPE_SOURCE;
>> + else if (dev->sink && avdtp_is_connected(&dev->src, &dev->dst))
>> return TYPE_SINK;
>
> I think the dev->source check should be in an "else if" clause while the
> dev->sink check should be first. I.e. if a device happens to support both
> roles of A2DP we default to dev->sink.
Good catches, perhaps we should consider doing avdtp_is_connected
check before checking for sink/source pointers. What do you think?
--
Luiz Augusto von Dentz
Engenheiro de Computação
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
