On Wed, Jul 15, 2009 at 3:11 PM, Nick Pelly<npelly@xxxxxxxxxx> wrote: > On Tue, Jul 14, 2009 at 9:15 AM, Nick Pelly<npelly@xxxxxxxxxx> wrote: >> On Mon, Jul 13, 2009 at 2:27 PM, Luiz Augusto von >> Dentz<luiz.dentz@xxxxxxxxx> wrote: >>> Hi Nick, >>> >>> On Mon, Jul 13, 2009 at 12:46 PM, Nick Pelly<npelly@xxxxxxxxxx> wrote: >>>> Any comments on this patch? >>>> >>>> It works for me, but my understanding of the RFCOMM state machine is naive. >>>> >>> >>> iirc BT_CONFIG(PN frame) means the DLC is being configured than we got >>> into connecting phase (BT_CONNECT) and send SABM frame. Only when >>> receiving UA frame DLC is consider connected (BT_CONNECTED), so your >>> patch seems good by assuming that we don't need to send a DISC for a >>> DLC not connected. But there is still a good use for it to cancel the >>> DLC connection attempt, so perhaps a better alternative would be to >>> use a much shorter timeout in those cases. >> >> Thanks for the advice. >> >> I have prepared a new patch which uses a very short timeout (10ms) on >> the DLC disconnect when in BT_CONFIG. I have tested this patch and it >> also resolves the issue. Patch attached. > > ping > > I will be offline for 2 weeks from tomorrow, so if there is further > testing or patches you would like me to try then I won't be able to > help after tomorrow. ping. Looking for 'yes this is ok, patch merged' or 'no this is not ok, because....' Nick -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
