RE: [PATCH] Bluetooth: Fix incorrect alignment in Marvell BT-over-SDIO driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marcel,

This patch fixed the alignment issue and the compilation warnings on 64-bit system.
I also tested some basic commands (scan, l2ping, etc.) on my 64-bit HP laptop and they seem working fine.

Should you have any other commands for testing/verification, or items for cleanup please let me know.

Thanks much for your help.

Bing

> -----Original Message-----
> From: Marcel Holtmann [mailto:marcel@xxxxxxxxxxxx]
> Sent: Wednesday, July 08, 2009 11:54 AM
> To: Bing Zhao
> Cc: linux-bluetooth@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] Bluetooth: Fix incorrect alignment in Marvell BT-over-SDIO driver
> 
> Hi Bing,
> 
> > The driver uses "u32" for alignment check and calculation which
> > works only on 32-bit system. It will crash the 64-bit system.
> > Replace "u32" with "unsigned long" to fix this issue.
> 
> I pushed that patch into the bluetooth-mrvl-2.6 tree now.
> 
> However I am pretty sure that are better "Linux" ways on handling the
> alignment for the SKBs.
> 
> Regards
> 
> Marcel
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux