Hi Forrest,
On Wed, Jun 10, 2009, Forrest Zhao wrote:
> ---
> plugins/ebook.c | 344 ++++++++++++++++++++++++++++++++++++++++++++++++++++--
> test/pbap-client | 1 +
> 2 files changed, 334 insertions(+), 11 deletions(-)
The patch has now been pushed with a few minor changes:
> +#define DEFAULT_COUNT 65535
Space instead of tab since there's no special indentation needed for the
value.
> + gint32 i;
> + const char *attrib_name = e_vcard_attribute_get_name(
> + (EVCardAttribute *)l->data);
> +
> + for (i = 0; i <= 28; i++) {
No need to have a specialized gint32 variable type here. Just use int.
> + gint32 i;
> + const char *attrib_name = e_vcard_attribute_get_name(
> + (EVCardAttribute *)l->data);
> + for (i = 0; i <= 28; i++) {
Same here.
About the vcard generation. Would it make sense to make some common helper
module for it so other contact backends woldn't need to duplicate all of
it?
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
