Hi Marcel, > -----Original Message----- > From: Marcel Holtmann [mailto:marcel@xxxxxxxxxxxx] > Sent: Tuesday, June 09, 2009 8:20 AM > To: Bing Zhao > Cc: linux-bluetooth@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/4 v3] bluetooth: add btmrvl driver to support Marvell bluetooth devices > > Hi Bing, > > > This driver provides basic definitions and library functions to > > support Marvell Bluetooth enabled devices, such as 88W8688 WLAN/BT > > combo chip. > > so I created a bluetooth-mrvl-2.6 tree with your patches and already a > major collection of cleanup patches. Thanks for the cleanups. > The biggest problem right now is that your driver spits out casting > warnings like crazy. This is not acceptable. So please send me a patch > to fix these based on bluetooth-mrvl-2.6. Could you please let me know how to catch these casting warnings? I'm using GCC 4.3.2 with sparse on x86 laptop (Fedora 8) but I couldn't get the warnings. > I did fix the firmware non-sense you had in there, but I haven't had > time to test it with real hardware. So please do so. Thanks for the fix and it works well. > Also I am considering to just remove all this Enter/Leave debug > non-sense since it makes the code really hard to read. I can remove those Enter/Leave debug, if you prefer. > Regards > > Marcel > Thanks, Bing -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
